Skip to content

[REFACTOR] 영어 교정 한국어 - #136

Merged
hyeonky0w0 merged 2 commits into
developfrom
refactor/#135
Aug 12, 2026
Merged

[REFACTOR] 영어 교정 한국어#136
hyeonky0w0 merged 2 commits into
developfrom
refactor/#135

Conversation

@hyeonky0w0

@hyeonky0w0 hyeonky0w0 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📌 관련 이슈

✨ 작업 내용

  • 영어 교정문 해설이 영어로 나오던걸 한국어로 변경하였습니다.

📸 UI 작업 시

✅ 체크 리스트

  • develop 브랜치를 pull 완료했는가?
  • Merge 하려는 브랜치가 올바른가?
  • Merge 하려는 PR 및 Commit들을 로컬에서 실행했을 때 에러가 발생하지 않았는가?

Summary by CodeRabbit

  • 개선 사항
    • 답변 교정 시 교정 이유는 한국어로, 교정된 문장과 대체 표현은 영어로 제공되도록 안내를 명확히 했습니다.
  • 테스트
    • 각 교정 결과 항목의 언어가 올바르게 생성되는지 검증을 강화했습니다.

@hyeonky0w0 hyeonky0w0 self-assigned this Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@hyeonky0w0, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a068da9-64e0-44c1-8e7f-adaa56477fa6

📥 Commits

Reviewing files that changed from the base of the PR and between f26f6f0 and 9a16afe.

📒 Files selected for processing (3)
  • src/main/java/com/example/todayEng/domain/diary/client/AnswerCorrectionLanguageValidator.java
  • src/main/java/com/example/todayEng/domain/diary/client/GeminiAnswerCorrectionLlmClient.java
  • src/test/java/com/example/todayEng/domain/diary/client/AnswerCorrectionLanguageValidatorTest.java
📝 Walkthrough

Walkthrough

답변 교정 프롬프트가 필드별 언어 규칙을 사용하도록 변경되었습니다. correctionReason는 한국어로, correctedTextalternativeExpressions는 영어로 작성하도록 지정했습니다. 테스트는 이 지시를 검증합니다.

Changes

답변 교정 언어 규칙

Layer / File(s) Summary
교정 출력 언어 규칙 적용
src/main/java/com/example/todayEng/domain/diary/prompt/AnswerCorrectionPromptFactory.java, src/test/java/com/example/todayEng/domain/diary/prompt/AnswerCorrectionPromptFactoryTest.java
프롬프트가 correctionReason를 한국어로 작성하도록 지정합니다. correctedTextalternativeExpressions는 영어로 유지하도록 지정합니다. 테스트가 해당 언어 지시를 확인합니다.

Estimated code review effort: 1 (단순) | ~5분

Poem

한국어 이유는 또렷하게,
영어 교정은 자연스럽게.
사실은 더하지 않고,
테스트가 규칙을 지켜요.
프롬프트도 언어 공부 완료!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 영어 교정 이유를 한국어로 제공하는 주요 변경 사항을 간결하게 설명합니다.
Linked Issues check ✅ Passed 프롬프트가 correctionReason을 한국어로 지정하여 이슈 #135의 핵심 요구 사항을 충족합니다.
Out of Scope Changes check ✅ Passed 변경 사항은 언어별 출력 규칙과 해당 테스트에 한정되며, 이슈 #135의 범위를 벗어나지 않습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#135

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/main/java/com/example/todayEng/domain/diary/prompt/AnswerCorrectionPromptFactory.java`:
- Around line 16-18: Update the response validation in validate(...) within
AnswerCorrectionPromptFactory to enforce the field language contract at runtime:
correctionReason must be Korean, while correctedText and every
alternativeExpressions entry must be English. When validation fails, return
INVALID_LLM_RESPONSE and apply the existing fallback before complete(...) or SSE
notification processing.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ec6872ea-beac-4bd8-bbec-61d759c2b502

📥 Commits

Reviewing files that changed from the base of the PR and between 17f1d8e and f26f6f0.

📒 Files selected for processing (2)
  • src/main/java/com/example/todayEng/domain/diary/prompt/AnswerCorrectionPromptFactory.java
  • src/test/java/com/example/todayEng/domain/diary/prompt/AnswerCorrectionPromptFactoryTest.java

@riveryunny riveryunny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@hyeonky0w0
hyeonky0w0 merged commit c903743 into develop Aug 12, 2026
2 checks passed
@ownue
ownue deleted the refactor/#135 branch August 13, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️[REFACTOR] 영어 교정 이유는 한국어로

2 participants